Address concerns about CSSStyleSheet-constructable-concat.html #43377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 27, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5062333
branch
from
a9d6511
to
8c1034f
Compare
See [1] for comments, but this CL adds reftest-wait to ensure the test finishes before the image capture, and adds PASS lines for all passed tests. This makes no difference in Chromium, but ensures this test works correctly in other browsers. [1] #43310 Bug: 1236777 Change-Id: I849284eafdd0afb630a11b0a9e6b73bc0264fd6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5062333 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1229509}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5062333
branch
from
8c1034f
to
29e3f1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See [1] for comments, but this CL adds reftest-wait to ensure
the test finishes before the image capture, and adds PASS lines
for all passed tests.
This makes no difference in Chromium, but ensures this test
works correctly in other browsers.
[1] #43310
Bug: 1236777
Change-Id: I849284eafdd0afb630a11b0a9e6b73bc0264fd6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5062333
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1229509}