Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map flexbox tests to web-features #43702

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

foolip
Copy link
Member

@foolip foolip commented Dec 18, 2023

For flex gap, enumerate the relevant tests, with a TODO to use wildcards
when that is supported.

@@ -0,0 +1,54 @@
features:
- name: flexbox
files: "**"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under the current logic:
In this current configuration: flexbox and flexbox-gap will have some overlapping features. Both will have column-reverse-gap.html (due to flexbox's ** and flexbox-gap's explicit listing of column-reverse-gap.html)

Or are you expecting different behavior?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm expecting that flexbox-gap will "steal" the features from flexbox, similar to how the recursive behavior works.

@cbiesinger cbiesinger requested review from davidsgrogan and removed request for cbiesinger December 18, 2023 15:24
This includes tests for flex gap which should ideally be mapped to
flexbox-gap, but that's not easy to do without the tests being mapped to
both features at the same time, since most tests are in the same
directory and there's no support for exclusions. A TODO describes the
situation.
@foolip
Copy link
Member Author

foolip commented Apr 18, 2024

I've dropped the flexbox-gap mapping as that complicates things. @jcscottiii I looked into moving the tests into a directory as we discussed some time ago. I had to decide against that, since those tests are labeled as interop-2021-flexbox, which is part of Layout in https://wpt.fyi/interop-2024. Renames affect the scores of the pre-rename runs, so there's no way to do this without it appearing like a test result change, which would be misleading.

Moving the files would be easy to do once flex gap isn't part of Interop, maybe in 2025.

@foolip foolip merged commit 5adfe4e into web-platform-tests:master Apr 18, 2024
19 checks passed
@foolip foolip deleted the web-features-flexbox branch April 18, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants