-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map flexbox tests to web-features #43702
Conversation
@@ -0,0 +1,54 @@ | |||
features: | |||
- name: flexbox | |||
files: "**" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under the current logic:
In this current configuration: flexbox
and flexbox-gap
will have some overlapping features. Both will have column-reverse-gap.html
(due to flexbox
's **
and flexbox-gap
's explicit listing of column-reverse-gap.html
)
Or are you expecting different behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm expecting that flexbox-gap
will "steal" the features from flexbox
, similar to how the recursive behavior works.
This includes tests for flex gap which should ideally be mapped to flexbox-gap, but that's not easy to do without the tests being mapped to both features at the same time, since most tests are in the same directory and there's no support for exclusions. A TODO describes the situation.
5a6fde0
to
bf960cc
Compare
I've dropped the Moving the files would be easy to do once flex gap isn't part of Interop, maybe in 2025. |
For flex gap, enumerate the relevant tests, with a TODO to use wildcards
when that is supported.