-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync interfaces/ with @webref/idl 3.47.3 #46056
Conversation
a40984d
to
4e41c58
Compare
dc29871
to
acdd629
Compare
@foolip just wondering if there's anything blocking merging this PR |
acdd629
to
5c0c29c
Compare
85d2624
to
179b152
Compare
179b152
to
99dd1ed
Compare
@rakuco sure thing, anyone can review and merge these PRs, but I understand it's mysterious what should be checked. What I do is:
In this case there's a timeout, and I actually don't know what might cause that. Probably not the IDL changes however, so the first thing I'd try is closing and reopening the PR to rerun CI. If that fixes it I'll assume unrelated flakiness and merge. |
Thanks, @foolip, this is the information I'd been looking for! The webrtc timeout seems to be gone on Safari, so I guess we're good to go? |
@rakuco, yep, good to go! |
This automated pull request updates interfaces/*.idl from @webref/idl 3.47.3.
Before merging, please check that any tests that depend on the updated IDL files still work. In particular, check for gray boxes as the wpt.fyi check status, which usually means that some tests have regressed.
If additional changes are needed, please manually create another PR based on this one.
See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.