Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync interfaces/ with @webref/idl 3.47.3 #46056

Merged
merged 1 commit into from
May 21, 2024
Merged

Sync interfaces/ with @webref/idl 3.47.3 #46056

merged 1 commit into from
May 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 3, 2024

This automated pull request updates interfaces/*.idl from @webref/idl 3.47.3.

Before merging, please check that any tests that depend on the updated IDL files still work. In particular, check for gray boxes as the wpt.fyi check status, which usually means that some tests have regressed.

If additional changes are needed, please manually create another PR based on this one.

See the workflow for how this pull request was created, and the README for how the IDL files in this directory are used.

@wpt-pr-bot wpt-pr-bot requested a review from foolip May 3, 2024 12:09
@github-actions github-actions bot force-pushed the actions/update-idl branch 7 times, most recently from a40984d to 4e41c58 Compare May 10, 2024 12:09
@github-actions github-actions bot force-pushed the actions/update-idl branch 4 times, most recently from dc29871 to acdd629 Compare May 15, 2024 12:11
@rakuco
Copy link
Member

rakuco commented May 15, 2024

@foolip just wondering if there's anything blocking merging this PR

@github-actions github-actions bot changed the title Sync interfaces/ with @webref/idl 3.47.2 Sync interfaces/ with @webref/idl 3.47.3 May 17, 2024
@github-actions github-actions bot force-pushed the actions/update-idl branch 4 times, most recently from 85d2624 to 179b152 Compare May 20, 2024 12:12
@foolip
Copy link
Member

foolip commented May 21, 2024

@rakuco sure thing, anyone can review and merge these PRs, but I understand it's mysterious what should be checked. What I do is:

In this case there's a timeout, and I actually don't know what might cause that. Probably not the IDL changes however, so the first thing I'd try is closing and reopening the PR to rerun CI. If that fixes it I'll assume unrelated flakiness and merge.

@rakuco
Copy link
Member

rakuco commented May 21, 2024

Thanks, @foolip, this is the information I'd been looking for! The webrtc timeout seems to be gone on Safari, so I guess we're good to go?

@foolip
Copy link
Member

foolip commented May 21, 2024

@rakuco, yep, good to go!

@foolip foolip merged commit dc5e9da into master May 21, 2024
19 checks passed
@foolip foolip deleted the actions/update-idl branch May 21, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants