New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for nomodule content attribute on script elements #4611

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
6 participants
@rniwa
Contributor

rniwa commented Jan 24, 2017

This feature is being added in whatwg/html#2261

Converted the tests in https://trac.webkit.org/r211078 to use testharness.js,
refined the test for IDL attribute reflecting content attribute, and re-organized tests.

@wpt-pr-bot

This comment has been minimized.

Show comment
Hide comment
Collaborator

wpt-pr-bot commented Jan 24, 2017

@wpt-pr-bot wpt-pr-bot added the html label Jan 24, 2017

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Jan 24, 2017

Contributor

FAIL: 20/10 says https://travis-ci.org/w3c/web-platform-tests/jobs/194747170

@jgraham what is the cause there?

Contributor

zcorpan commented Jan 24, 2017

FAIL: 20/10 says https://travis-ci.org/w3c/web-platform-tests/jobs/194747170

@jgraham what is the cause there?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Jan 24, 2017

Contributor

@sideshowbarker says the cause is duplicate test names.

Contributor

zcorpan commented Jan 24, 2017

@sideshowbarker says the cause is duplicate test names.

@rniwa

This comment has been minimized.

Show comment
Hide comment
@rniwa

rniwa Jan 26, 2017

Contributor

Ping reviewers. I've pushed a new commit after rebasing.

Contributor

rniwa commented Jan 26, 2017

Ping reviewers. I've pushed a new commit after rebasing.

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Jan 30, 2017

Contributor

LGTM except this comment appears to be unaddressed:
#4611 (comment)

Contributor

zcorpan commented Jan 30, 2017

LGTM except this comment appears to be unaddressed:
#4611 (comment)

Add tests for nomodule content attribute on script elements
This feature is being added in whatwg/html#2261

Converted the tests in https://trac.webkit.org/r211078 to use testharness.js,
refined the test for IDL attribute reflecting content attribute, and re-organized tests.
@rniwa

This comment has been minimized.

Show comment
Hide comment
@rniwa

rniwa Jan 31, 2017

Contributor

Oh strange. Removed for sure this time.

Contributor

rniwa commented Jan 31, 2017

Oh strange. Removed for sure this time.

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Jan 31, 2017

Member

Thanks so much!!

Member

domenic commented Jan 31, 2017

Thanks so much!!

@domenic domenic merged commit c4725e5 into web-platform-tests:master Jan 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmaher

This comment has been minimized.

Show comment
Hide comment
@jmaher

jmaher Mar 24, 2017

Contributor

@rniwa we run this test in automation at Mozilla and there are intermittent failures (we set this to expect failure and it intermittently passes) as documented in https://bugzilla.mozilla.org/show_bug.cgi?id=1344486. Is there more we can do to make this test stable?

Contributor

jmaher commented Mar 24, 2017

@rniwa we run this test in automation at Mozilla and there are intermittent failures (we set this to expect failure and it intermittently passes) as documented in https://bugzilla.mozilla.org/show_bug.cgi?id=1344486. Is there more we can do to make this test stable?

@zcorpan

This comment has been minimized.

Show comment
Hide comment
@zcorpan

zcorpan Mar 24, 2017

Contributor

You could add a feature check and fail the test early if noModule is not supported.

Contributor

zcorpan commented Mar 24, 2017

You could add a feature check and fail the test early if noModule is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment