Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebNN: Allow 0-D (scalar) reductions #46209

Merged
merged 1 commit into from
May 15, 2024

Commits on May 15, 2024

  1. WebNN: Allow 0-D (scalar) reductions

    crrev.com/c/5448942 added a restriction on the reduction ops
    (including argMin/argMax) that the rank of the input tensor must be
    greater than zero.
    
    In webmachinelearning/webnn#681, @fdwr
    points out that 0-D (scalar) reductions are fine, it's just a no-op.
    Per that discussion, this removes a restriction. There are already
    WPT cases for argMin/argMax (although they fail for other reasons);
    cases are added for the plethora of reduction ops (which also fail
    for other reasons).
    
    Change-Id: Ib10a9b0bb3062f9d2b6001d9a4963b14e751d14f
    Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5529350
    Reviewed-by: Phillis Tang <phillis@chromium.org>
    Reviewed-by: ningxin hu <ningxin.hu@intel.com>
    Commit-Queue: Joshua Bell <jsbell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1301369}
    inexorabletash authored and chromium-wpt-export-bot committed May 15, 2024
    Configuration menu
    Copy the full SHA
    98a2e69 View commit details
    Browse the repository at this point in the history