Increase timeout on callback-cross-realm-report-exception.html #46789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intersection-observer variant of this test would occasionally flake on slow bots. A potential reason is that the timeout is too low. This patch speculatively updates the test to use 100ms, matching the timeout used by animation-frames/callback-cross-realm-report-exception.html. Bug: 41494443 Change-Id: I335637db83d9d85b714b8a90b803054152b9f9dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634864 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1315898}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5634864
branch
from
e4cf967
to
9d7cf3b
Compare
wpt-pr-bot
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intersection-observer variant of this test would occasionally flake
on slow bots. A potential reason is that the timeout is too low. This
patch speculatively updates the test to use 100ms, matching the timeout
used by animation-frames/callback-cross-realm-report-exception.html.
Bug: 41494443
Change-Id: I335637db83d9d85b714b8a90b803054152b9f9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5634864
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Auto-Submit: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1315898}