Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to confirm document's location getter returns null outside of a browsing context. #7574

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented Oct 4, 2017

Rebased from #1757.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming all browsers will pass. If they don't, I'd like to see a reference to what bit of spec defines this.

@w3c-bots
Copy link

w3c-bots commented Oct 4, 2017

Build PASSED

Started: 2017-10-06 09:34:44
Finished: 2017-10-06 09:42:00

View more information about this build on:

@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 4, 2017

@ashughes1 It looks like

      assert_equals(win.location, null);

is failing in location_getter.html. The spec also doesn't seem to support it. Do you remember where that check came from?

CC @annevk

@annevk
Copy link
Member

annevk commented Oct 4, 2017

@Ms2ger see whatwg/html#2545 (comment). Seems only Firefox fixed its issue thus far.

@ghost
Copy link

ghost commented Oct 5, 2017

@ashughes1 It looks like

  assert_equals(win.location, null);

is failing in location_getter.html. The spec also doesn't seem to support it. Do you remember where that check came from?

I'm sorry, I do not recall. It's been 2.5 years since I looked at this.

@Ms2ger Ms2ger changed the title Add tests to confirm document/window location getters are null outside of browser context. Add tests to confirm document's location getter returns null outside of a browsing context. Oct 6, 2017
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Oct 6, 2017

We're claiming that the window test is covered by #5778.

@Ms2ger Ms2ger merged commit 60a23aa into master Oct 6, 2017
@Ms2ger Ms2ger deleted the location-getters branch October 6, 2017 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants