Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Picture-in-Picture] Add Shadow DOM support for pictureInPictureElement #9387

Merged
merged 1 commit into from
Feb 9, 2018

Commits on Feb 9, 2018

  1. [Picture-in-Picture] Add Shadow DOM support for pictureInPictureElement

    Until now, pictureInPictureElement was supported only in Document. This
    CL makes it compliant with the spec by adding Shadow DOM support to
    pictureInPictureElement. Note that I wish I could have used a partial
    interface DocumentOrShadowRoot but partial interface for mix-in IDL are
    not supported at that time (crbug.com/656517).
    
    Bug: 806249, 656517
    Change-Id: I5f9666ea9c52ded9a6d07a238fc7756371b7550e
    Reviewed-on: https://chromium-review.googlesource.com/897513
    Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: apacible <apacible@chromium.org>
    Reviewed-by: Hayato Ito <hayato@chromium.org>
    Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
    Reviewed-by: Kentaro Hara <haraken@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#535747}
    beaufortfrancois authored and chromium-wpt-export-bot committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    465e2a5 View commit details
    Browse the repository at this point in the history