Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl_encrypt() expects at most 5 parameters, 6 given #11

Closed

Conversation

jonathanpmartins
Copy link

Like documentation, openssl_encrypt only receives 5 parameters: http://php.net/manual/en/function.openssl-encrypt.php

@Minishlink
Copy link
Member

Minishlink commented Apr 20, 2016

The line that you are editing should not be executed in your environment because PHP 7.1 is not even out in beta yet. openssl_encrypt will have at least 6 parameters (even 7 if I remember correctly, with $aad) at this point. (see this PHP RFC)

If you're encountering an issue using the payload branch, please by all means file an issue and report what exact PHP version you are using, or comment on the PR #1.

Thanks for contributing anyway. :)

@Minishlink Minishlink closed this Apr 20, 2016
@Minishlink Minishlink mentioned this pull request Apr 20, 2016
@jonathanpmartins
Copy link
Author

@Minishlink
Sorry, too many hours working, hehehehe
Im using PHP 7.0.5... For now, Im using a node server to encrypt my payloads, its faster.
Do you know if the encryption will be faster in PHP 7.1 ?

@Minishlink
Copy link
Member

No problem. ;)

It wouldn't surprise me that Node.js uses OpenSSL under the hood, so I guess the performance will be somewhat equal. This will indeed be an interesting benchmark once the new openssl_encrypt is merged into PHP. (>=7.1) At this very moment, I can't guarantee you any information, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants