tech(config): set and get config from json #50
Conversation
| @@ -0,0 +1 @@ | |||
| {"secret":"encrypt","algorithm":"AES"} | |||
There was a problem hiding this comment.
algorithm value not used?
There was a problem hiding this comment.
Yes. For now, created the config method and just used the secret. But this solution may not work. Since the config is based on a file on each config set the file will get overridden. So need to think of some alternate solution to maintain the config object instead of keeping the values in a file.
CONVERTED TO DRAFT PR
|
Converted the PR to |
| import { isUrl, isPatternUrl, isPatterObject, isPattern, isPath } from '../util' | ||
|
|
||
| const configData = fs.readFileSync(__dirname + '/config.json', 'utf8') |
There was a problem hiding this comment.
can this be template literal like below.
const configFile = 'config.json'
fs.readFileSync(`${__dirname}/${configFile}`, 'utf8')
There was a problem hiding this comment.
Yes, it can be. Refer Comment
| import { isUrl, isPatternUrl, isPatterObject, isPattern, isPath } from '../util' | ||
|
|
||
| const configData = fs.readFileSync(__dirname + '/config.json', 'utf8') | ||
| const configObject = JSON.parse(configData) |
There was a problem hiding this comment.
JSON.parse should be inside try / catch block. there is possibility of circular exception error. can be like below.
let moduleConfig = {}
try {
moduleConfig = JSON.parse(configData)
} catch (e) {
}
There was a problem hiding this comment.
Sure will work on it.
| return { | ||
| config: function (config = {}) { | ||
| if (Object.keys(config).length === 0) | ||
| throw new Error('options is missing') |
There was a problem hiding this comment.
move all error messages to errorMessages.js
There was a problem hiding this comment.
sure will do that
Get and Set JSON using a key from a file.
Fixes #47