feat: reduce the frequency of cache revalidation

web-widget · Jun 5, 2024 · 0847567 · 0847567
1 parent 8d77422
commit 0847567
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 42 deletions.
diff --git a/.changeset/little-parrots-roll.md b/.changeset/little-parrots-roll.md
@@ -0,0 +1,5 @@
+---
+"@web-widget/shared-cache": patch
+---
+
+Reduce the frequency of cache revalidation.
diff --git a/package.json b/package.json
@@ -70,7 +70,7 @@
     "lru-cache": "^10.2.0"
   },
   "dependencies": {
-    "@web-widget/http-cache-semantics": "^1.0.0",
+    "@web-widget/http-cache-semantics": "^1.1.0",
     "@web-widget/helpers": "^1.10.37"
   },
   "packageManager": "pnpm@8.4.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/cache.ts b/src/cache.ts
@@ -170,7 +170,12 @@ export class SharedCache implements Cache {
       headers,
     });
 
-    if (!forceCache && !policy.satisfiesWithoutRevalidation(r)) {
+    if (
+      !forceCache &&
+      !policy.satisfiesWithoutRevalidation(r, {
+        ignoreSearch: true,
+      })
+    ) {
       if (policy.stale() && policy.useStaleWhileRevalidate()) {
         // Well actually, in this case it's fine to return the stale response.
         // But we'll update the cache in the background.
@@ -334,7 +339,9 @@ export class SharedCache implements Cache {
     fetch: typeof globalThis.fetch
   ): Promise<Response> {
     const revalidationRequest = new Request(request, {
-      headers: resolveCacheItem.policy.revalidationHeaders(request),
+      headers: resolveCacheItem.policy.revalidationHeaders(request, {
+        ignoreSearch: true,
+      }),
     });
     let revalidationResponse: Response;