boolean in MSSQL2Adapter

[ilvalle]

The boolean data type is mapped to bit or boolean for all mssql adapters but MSSQL2Adapter.
Is there a special reason?

[niphlod]

historical ones. mssql2:// is rather an experiment.

[ilvalle]

Given that, I'd set boolean as bit.

[mdipierro]

No. That would break existing code. MSSQL2Adapter was created for those users who wanted a non-boolean mapping. We do not know that somebody is not relying on it. Why do you want to change it?

On Feb 17, 2015, at 9:45 AM, Paolo Valleri notifications@github.com wrote:

Given that, I'd set boolean as bit.

—
Reply to this email directly or view it on GitHub.

[ilvalle]

I use MSSQL2Adapter for a legacy db where boolean types are defined as bit. I fixed it on my local copy. If MSSQL2Adapter is marked experimental, we can still update it?

[niphlod]

Mssql2 is a proof of concept of using unicode-capable fields. It's legacy,old and should be reviewed. Of course changing boolean mapping will break compatibility with current models

[ilvalle]

@mdipierro I've just realized that MSSQL2Adapter is broken anyway.
The following return False.

db = DAL('mssql2://user:passwd@ip/db')
db.define_table('tt', Field('aa', 'boolean', default=True))
db.tt.insert(aa=True)
db().select(db.tt.aa)[0].aa == True

Given that I guess no one is really using this adapter. Despite the backward compatibility, I propose to update it by switching the boolean type from CHAR(1) to BIT

[mdipierro]

We do not know that nobody is using it. Can we make another one and
deprecate this?
On Mar 25, 2015 12:37 AM, "Paolo Valleri" notifications@github.com wrote:

@mdipierro https://github.com/mdipierro I've just realized that
MSSQL2Adapter is broken anyway.
The following return False.

db = DAL('mssql2://user:passwd@ip/db')
db.define_table('tt', Field('aa', 'boolean', default=True))
db.tt.insert(aa=True)
db().select(db.tt.aa)[0].aa == True

Given that I guess no one is really using this adapter. Despite the
backward compatibility, I propose to update it by switching the boolean
type from CHAR(1) to BIT

—
Reply to this email directly or view it on GitHub
#62 (comment).

[ilvalle]

Yes we could. The fact is that, the adapter is broken in a very basic operation. Given that I think we are in the position of fixing and breaking the compatibility, isn't?

[mdipierro]

Will not be able to look at the code until later. Meanwhile feel free to
make a pr
On Mar 25, 2015 9:28 AM, "Paolo Valleri" notifications@github.com wrote:

Yes we could. The fact is that, the adapter is broken in a very basic
operation. Given that I think we are in the position of fixing and breaking
the compatibility, isn't?

—
Reply to this email directly or view it on GitHub
#62 (comment).