Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose API for uploading CAR files #288

Closed
mikeal opened this issue Aug 3, 2021 · 1 comment · Fixed by #293
Closed

Expose API for uploading CAR files #288

mikeal opened this issue Aug 3, 2021 · 1 comment · Fixed by #293
Assignees
@terichadbourne
Labels
kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up

Comments

@mikeal
Copy link

mikeal commented Aug 3, 2021

We just need to abstract the current put() method a little. Probably turn this into an _ method https://github.com/web3-storage/web3.storage/blob/main/packages/client/src/lib.js#L131 and write a small function on top like “putCAR()” to call the _ method.
@mikeal mikeal added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels Aug 3, 2021
@mikeal mikeal changed the title Expose API for upload CAR files Expose API for uploading CAR files Aug 3, 2021
@terichadbourne terichadbourne self-assigned this Aug 3, 2021
@terichadbourne
Copy link
Contributor

Taking a first stab at this at Mikeal's request; hope to circle back this afternoon with a draft.

@dchoi27 dchoi27 added P1 High: Likely tackled by core team if no one steps up and removed need/triage Needs initial labeling and prioritization labels Aug 3, 2021
@terichadbourne terichadbourne mentioned this issue Aug 3, 2021
Merged
alanshaw pushed a commit that referenced this issue Aug 11, 2021
@terichadbourne
feat: add method for uploading CAR files (#293)
3f6b6d3 
resolves #288
@github-actions github-actions bot mentioned this issue Jan 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terichadbourne terichadbourne

Labels
kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
3 participants
@mikeal @dchoi27 @terichadbourne