Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login screens jarring #1446

Merged
merged 2 commits into from
Jun 14, 2022
Merged

fix: login screens jarring #1446

merged 2 commits into from
Jun 14, 2022

Conversation

drewdelano
Copy link
Contributor

Closes #1440

Switches the "callback" route to product-app to fix the background

Uses flexbox to position the footer for product-app

@drewdelano drewdelano linked an issue Jun 10, 2022 that may be closed by this pull request
2 tasks
@drewdelano drewdelano changed the title Fix login screens jarring fix: login screens jarring Jun 11, 2022
@drewdelano drewdelano marked this pull request as ready for review June 13, 2022 16:11
@JeffLowe
Copy link

Visual inspection of the login flow on the preview link:
Look much better. Login screen footer anchored at bottom so no whitespace under footer.
The callback screen now uses the site's darker background and styled loader animation.
@drewdelano Question: Is there a way to change the white magic auth screen to darker color? Is that something we have to do in magicauth settings (thus only someone with access can accomplish)?

@drewdelano
Copy link
Contributor Author

drewdelano commented Jun 14, 2022

@JeffLowe I suspect so, but I can take a look too.

@JeffLowe
Copy link

@drewdelano dont let the magiclink screen block getting this pr's improvements out. We can always circle back (in new ticket) to address the magiclink screen.

@drewdelano
Copy link
Contributor Author

I talked with @JeffLowe about this on Slack. I'm going to go ahead and merge this. I'll fix the magic link bit in another ticket he's creating now.

@drewdelano drewdelano merged commit 87554bd into main Jun 14, 2022
@drewdelano drewdelano deleted the fix/1440-login-screens-jarring branch June 14, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login screens jarring white background and height issues
3 participants