Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txpool management API's implemented (web3-eth-txpool) #2659

Merged
merged 22 commits into from
Apr 15, 2019

Conversation

princesinha19
Copy link
Contributor

@princesinha19 princesinha19 commented Apr 7, 2019

Description

I implemented all txpool management API's provided by geth.
https://github.com/ethereum/go-ethereum/wiki/Management-APIs#list-of-management-apis

Fixes partially #2637

Type of change

  • New feature

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no warnings.
  • I have updated or added types for all modules I've changed
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run test in the root folder with success and extended the tests if necessary.
  • I ran npm run build in the root folder and tested it in the browser and with node.
  • I ran npm run dtslint in the root folder and tested that all my types are correct
  • I have tested my code on an ethereum test network.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 95.428% when pulling b4e43ee on princesinha19:txpool-methods into 839283a on ethereum:1.0.

@coveralls
Copy link

coveralls commented Apr 7, 2019

Coverage Status

Coverage increased (+0.05%) to 95.491% when pulling 32ab9de on princesinha19:txpool-methods into 5e4724b on ethereum:1.0.

@nivida nivida added Feature Request In Progress Currently being worked on labels Apr 8, 2019
@nivida nivida removed the In Progress Currently being worked on label Apr 8, 2019
@joshstevens19
Copy link
Contributor

If this has to get to through web3.eth you have to add this to the Eth typings class or it wont be exposed in the global scope when ts users try to use it.

https://github.com/ethereum/web3.js/blob/1.0/packages/web3-eth/types/index.d.ts

Please add it

@princesinha19
Copy link
Contributor Author

@joshstevens19 Done changes.

@princesinha19
Copy link
Contributor Author

@joshstevens19 thanks for your suggestions. So, I removed this module to get exposed through web3.eth. So, can you please review the new commit?

docs/web3-eth-txpool.rst Outdated Show resolved Hide resolved
packages/web3-eth-txpool/rollup.config.js Outdated Show resolved Hide resolved
packages/web3-eth/types/tests/eth.tests.ts Outdated Show resolved Hide resolved
packages/web3-eth-txpool/src/Txpool.js Outdated Show resolved Hide resolved
packages/web3-eth-txpool/package.json Show resolved Hide resolved
@nivida nivida merged commit 07f80b4 into web3:1.0 Apr 15, 2019
@princesinha19 princesinha19 deleted the txpool-methods branch April 23, 2019 09:33
@nivida nivida mentioned this pull request Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants