Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receipt added to transaction errors #3259

Merged
merged 4 commits into from
Dec 9, 2019
Merged

Receipt added to transaction errors #3259

merged 4 commits into from
Dec 9, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Dec 6, 2019 •
edited

Description

Improves the consistency of the returned error interfaces.

Type of change

  • Enhancement

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@nivida nivida added Enhancement Includes improvements or optimizations 1.x 1.0 related issues labels Dec 6, 2019
@nivida nivida marked this pull request as ready for review December 6, 2019 10:27
@nivida nivida requested a review from cgewecke December 6, 2019 10:27
@coveralls
Copy link

coveralls commented Dec 6, 2019 •
edited

Coverage Status

Coverage increased (+0.04%) to 84.802% when pulling 0ff7669 on enhancement/add-receipt-to-errors into b35e418 on 1.x.

@nivida
eth.sendTransaction.revert test file added which does cover the added…
c6210c9 
… receipt property and additionaly does test the revert handling with directly calling of eth.sendTransaction
@nivida nivida added the Review Needed Maintainer(s) need to review label Dec 6, 2019
cgewecke
cgewecke approved these changes Dec 6, 2019
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks perfect to me.

@nivida nivida removed the Review Needed Maintainer(s) need to review label Dec 9, 2019
@nivida nivida merged commit 8804708 into 1.x Dec 9, 2019
@nivida nivida deleted the enhancement/add-receipt-to-errors branch December 12, 2019 08:35
@nivida nivida mentioned this pull request Jan 16, 2020
Merged
10 tasks
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Open
This was referenced Mar 31, 2020
Open
Open
Open
Open
This was referenced Apr 9, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nivida @coveralls @cgewecke