Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the possibility to define a custom registry for the ENS module #3301

Merged
merged 18 commits into from
Jan 20, 2020

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Jan 10, 2020

Description

This PR does extend the ENS module with the registryAddress property to define a custom registry and to store an already detected registry address. By side of the improvement of a stored registry address did I also improve the anyways changed checkNetwork method to only check the sync state of the node if at least an hour is gone. This because otherwise, it doesn't make sense to check it.

Fixes #3010

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success and extended the tests if necessary.
  • I ran npm run build-all and tested the resulting file/'s from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on a local test network.

…ustom registry and checkNetwork improved to only check the sync state if it does make sense
@nivida nivida added Feature Request 1.x 1.0 related issues labels Jan 10, 2020
@coveralls
Copy link

coveralls commented Jan 10, 2020

Coverage Status

Coverage increased (+0.06%) to 85.424% when pulling 69001c7 on issue/3010 into 513116f on 1.x.

@nivida nivida mentioned this pull request Jan 13, 2020
7 tasks
@nivida nivida marked this pull request as ready for review January 17, 2020 14:13
@nivida nivida added the Review Needed Maintainer(s) need to review label Jan 17, 2020
@nivida nivida requested a review from cgewecke January 17, 2020 14:13
docs/web3-eth-ens.rst Outdated Show resolved Hide resolved
@cgewecke cgewecke self-requested a review January 20, 2020 06:13
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect to me, awesome. 💯

I left one question and a couple small rewording suggestions for the docs.

@nivida
Copy link
Contributor Author

nivida commented Jan 20, 2020

@cgewecke Thanks for your review! I've fixed the commented typos with 69001c7

@nivida nivida removed the Review Needed Maintainer(s) need to review label Jan 20, 2020
@nivida nivida merged commit bc27652 into 1.x Jan 20, 2020
@nivida nivida deleted the issue/3010 branch January 21, 2020 09:24
@nivida nivida mentioned this pull request Jan 30, 2020
10 tasks
@cgewecke cgewecke mentioned this pull request Mar 22, 2020
13 tasks
@ryanio ryanio mentioned this pull request Apr 15, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Feature Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENS: option to use custom registry addresses
3 participants