-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure '0x' prefix exists (web3-eth-accounts) #3316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 💯
Out of curiousity, is there a reason why the implementation differs from the v2 branch? This would result in an extra breaking change going from v1 to v2 Either way, thanks for adding it in! |
@DalderupMaurice Oh thanks for commenting here! This is true, the implemented solution in 2.0 is the more advanced solution. This shouldn't introduce an extra breaking change but I will open a PR against 1.x asap with the solution implemented in 2.x thanks! |
Description
This PR ensures the '0x' prefix is always existing on a method call of the Accounts module.
Fixes #3041
Type of change
Checklist:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:unit
with success and extended the tests if necessary.npm run build-all
and tested the resulting file/'s fromdist
folder in a browser.CHANGELOG.md
file in the root folder.