-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: edit example error on utils-bn #3770
Conversation
This PR has been automatically marked as stale beacause it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
this is not stale PR.. :( |
|
Actually it looks like cla was added by automatically by our org rules. We will be removing that for web3.js |
In conclusion, do I not have to agree to the CLA up there? |
No please ignore it, ever since the repo transfer things got a little weird |
@cokia Is there a reason this was closed? |
I mistook this for a merged Pull Request. |
Actually, the correct value is 234. It should had been corrected to: |
This returns I'm going to close this because running: const BN = require('bignumber.js')
console.log(new BN('0xea').toString()) returns |
With bignumber.js - probably yes (I didn't check). With these two big number libraries - there's always some confusion... |
Description
corrected the error in the web3-utils document, in the example of BN.
The issue was generated here. #3762