Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create web3-eth-contract package structure for the 4.x #4565

Merged
merged 2 commits into from
Nov 22, 2021
Merged

Create web3-eth-contract package structure for the 4.x #4565

merged 2 commits into from
Nov 22, 2021

Conversation

nazarhussain
Copy link
Contributor

Description

Create skeleton for web3-eth-contract package.

Closes #4560

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain self-assigned this Nov 22, 2021
@nazarhussain nazarhussain linked an issue Nov 22, 2021 that may be closed by this pull request
Create web3-eth-contract package structure for the 4.x #4560
Closed
@nazarhussain nazarhussain added the 4.x 4.0 related label Nov 22, 2021
@nazarhussain nazarhussain merged commit 16abe31 into 4.x Nov 22, 2021
@nazarhussain nazarhussain deleted the nh/4560-web3-eth-contract-skeleton branch November 22, 2021 18:56
@adamlaska adamlaska mentioned this pull request Dec 7, 2023
Open
@baby636 baby636 mentioned this pull request Dec 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdevcs jdevcs jdevcs left review comments

@luu-alex luu-alex luu-alex approved these changes

@spacesailor24 spacesailor24 spacesailor24 approved these changes

Assignees

@nazarhussain nazarhussain

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create web3-eth-contract package structure for the 4.x
4 participants
@nazarhussain @spacesailor24 @luu-alex @jdevcs