-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Now we can remove the close event #4825
Conversation
and only let disconnect. Following web3#4786
@antonio-fr Please provide some reference for that standard change. |
Pull Request Test Coverage Report for Build 1941142164
💛 - Coveralls |
As describe in the initial related issue opened, Metamask informs that The event 'close' is deprecated and may be removed in the future. Please use 'disconnect' instead. For more information, see: https://eips.ethereum.org/EIPS/eip-1193#disconnect This current PR was proposed by @jdevcs who wrote to me in the issue "go ahead and open PR for removing close". The base working standard is EIP1193. This standard is the new Web3 standard, and it states there's a disconnect event, but no "close" event. The "close" event was deprecated by the PR #2586 in the EIP1193, which deprecated "close" in favor of "disconnect. The EIP1193 since clearly states : |
Many Thanks @antonio-fr for your contribution. Created #4839 as some tests were failing in this PR's github actions. |
and only let disconnect.
Following #4786
Description
Close event can now be removed. It is a deprecated event that is replaced by disconnect.
Type of change
Bug fix (non-breaking change which fixes an issue)
It was just a deprecation warning.
Checklist