Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation - Updated the ABI link #4905

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Documentation - Updated the ABI link #4905

merged 2 commits into from
Apr 11, 2022

Conversation

connoraleks
Copy link

The application binary interface link used to point to https://github.com/ethereum/wiki/wiki/Ethereum-Contract-ABI when it should point to https://docs.soliditylang.org/en/develop/abi-spec.html

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • [ X] Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [X ] I have selected the correct base branch.
  • [X ] I have performed a self-review of my own code.
  • [ X] I have commented my code, particularly in hard-to-understand areas.
  • [ X] I have made corresponding changes to the documentation.
  • [ X] My changes generate no new warnings.
  • [ X] Any dependent changes have been merged and published in downstream modules.
  • [ X] I ran npm run dtslint with success and extended the tests and types if necessary.
  • [ X] I ran npm run test:unit with success.
  • [ X] I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • [ X] I ran npm run build and tested dist/web3.min.js in a browser.
  • [X ] I have tested my code on the live network.
  • [X ] I have checked the Deploy Preview and it looks correct.
  • [ X] I have updated the CHANGELOG.md file in the root folder.

@nazarhussain nazarhussain added 1.x 1.0 related issues Review Needed Maintainer(s) need to review labels Mar 31, 2022
@jdevcs jdevcs added the Documentation Relates to project wiki or documentation label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Documentation Relates to project wiki or documentation Review Needed Maintainer(s) need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants