-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nicos99/revert call #6009
Merged
Merged
Nicos99/revert call #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)' to manage revert embedded error details got from some providers like MetaMask (related to issue #4454)
…llback(err, result)' to handle Revert in all cases: use `originalError` sub-object if provided
(resolved Conflicts for CHANGELOG.md)
…sendTxCallback(err, result)' to better manage revert call reason from some providers like MetaMask (related to issue #4454)
…ert-call-from-metamask (resoled Conflict with 'CHANGELOG.md' and 'packages/web3-core-method/src/index.js' caused last PR on the same bug)
luu-alex
requested review from
avkos,
jdevcs,
Muhammad-Altabba,
nikoulai and
spacesailor24
as code owners
April 13, 2023 15:17
Pull Request Test Coverage Report for Build 4690904761
💛 - Coveralls |
14 tasks
This was referenced Jun 1, 2023
This was referenced Sep 4, 2023
This was referenced Sep 18, 2023
This was referenced May 12, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From #5962, this PR is created so testcases can pass properly
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist for 1.x:
npm run dtslint
with success and extended the tests and types if necessary.npm run test:cov
and my test cases cover all the lines and branches of the added code.npm run build
with success.dist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.Checklist for 4.x:
yarn
successfullyyarn lint
successfullyyarn build:web
successfullyyarn test:unit
successfullyyarn test:integration
successfullycompile:contracts
successfullyCHANGELOG.md
file in the packages I have edited.