Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary chainId parameter (#5888) #6057

Merged
merged 2 commits into from
May 2, 2023

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented May 2, 2023

Description

Created this PR for changelog update and e2ewin tests of #5888

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Co-authored-by: Alex <alex.luu@mail.utoronto.ca>
Co-authored-by: Wyatt Barnes <me@wyatt.email>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs added the 1.x 1.0 related issues label May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Pull Request Test Coverage Report for Build 4860810584

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 75.139%

Totals Coverage Status
Change from base Build 4858743636: 0.0%
Covered Lines: 3353
Relevant Lines: 4212

💛 - Coveralls

@jdevcs jdevcs marked this pull request as ready for review May 2, 2023 12:16
@jdevcs
Copy link
Contributor Author

jdevcs commented May 2, 2023

All code changes in this PR are already approved in #5888 so merging in 1.x , Linting tests are not passing but its discussed in team meeting that we will go ahead with it as it will be fixed in next release auto ( due to cyclic deps )

@jdevcs jdevcs merged commit 13a2edc into 1.x May 2, 2023
@jdevcs jdevcs deleted the junaid/5949chainidparame2ewinandchanglog branch May 2, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants