-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken fetch for Node.js > 18.x and fixed double callback #6381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
August 26, 2023 03:57
Fixed tests for Node.js 16.x version which doesn't have globalThis.fetch by default. |
jdevcs
approved these changes
Aug 26, 2023
Merged
Closed
This was referenced Sep 18, 2023
This was referenced Nov 8, 2023
This was referenced Nov 23, 2023
This was referenced May 12, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5367, #6380
Description
Fixes #5367
Fixes #6380
https://stackoverflow.com/questions/73817412/why-is-the-agent-option-not-available-in-node-native-fetch
Please merge this PR as it is a CVE level bug for some environment using custom httpAgents ( Internal connections, etc ).
Without this patch, current Web3.js provider running on the latest Node.js LTS version could leak connection outside of the httpAgent proxy connections. ( As it will depend on the global.fetch which doesn't support agents natively )
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.