Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1/chore(web3-eth-accounts): bump @ethereumjs/common and @ethereumjs/tx #6457

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

legobeat
Copy link

@legobeat legobeat commented Sep 26, 2023

Description

The versions of @ethereumjs/ dependencies were pinned in #5529.

This retains the pin (uncertain why it was first introduced) but bumps them to latest within semver-major.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
    • Note: I do get a bunch of lint errors but these are unrelated and present on the base branch.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
    • This script does not exist on the 1.x branch.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@legobeat
Copy link
Author

legobeat commented Sep 26, 2023

@spacesailor24

@legobeat legobeat marked this pull request as ready for review September 26, 2023 03:20
Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dnt merge external PRs with following changes:

  • dist/ build output

  • package-lock files, ( If changes in packagelock are necessary thn one of our team member will do these in another PR )

@Muhammad-Altabba
Copy link
Contributor

Hi @legobeat
Did you face an issue that needed to update dependencies, in order to be fixed?
Thanks,

@legobeat
Copy link
Author

Hi @legobeat Did you face an issue that needed to update dependencies, in order to be fixed? Thanks,

Yes: To get the updates done in the updates in @etehreumjs/common, for example https://github.com/ethereumjs/ethereumjs-monorepo/releases/tag/%40ethereumjs%2Fcommon%402.6.5. Is there any reason to keep them frozen at legacy version?

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @legobeat for your contribution,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants