-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6344 - normalize v on recover #6462
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6462 +/- ##
=======================================
Coverage 89.39% 89.39%
=======================================
Files 212 212
Lines 8135 8137 +2
Branches 2212 2213 +1
=======================================
+ Hits 7272 7274 +2
Misses 863 863
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
fixes (#6344)
web3.js expected
v
to be either 27 or 28 and subtracts 27. but ledgerv
is always 0 or 1.This pr normalizes
v
only when it is greater than 26.Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.