Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cross-fetch to version 4 #6463

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Bump cross-fetch to version 4 #6463

merged 3 commits into from
Oct 2, 2023

Conversation

rdvorkin
Copy link
Contributor

Fixes issues like lquixada/cross-fetch#78, enabling to run web3.js in service worker

Fixes issues like lquixada/cross-fetch#78, enabling to run web3.js in service worker
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #6463 (90f5151) into 4.x (4b445ae) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6463   +/-   ##
=======================================
  Coverage   89.39%   89.39%           
=======================================
  Files         212      212           
  Lines        8137     8137           
  Branches     2213     2213           
=======================================
  Hits         7274     7274           
  Misses        863      863           
Flag Coverage Δ
UnitTests 89.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@luu-alex
Copy link
Contributor

Changelog needs to be updated

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, update changelog as mentioned by Alex

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rdvorkin,
I also updated the CHANGELOG.md file

@luu-alex luu-alex merged commit bfcbea8 into web3:4.x Oct 2, 2023
59 of 63 checks passed
@jdevcs jdevcs mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants