Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bigint power #7054

Merged
merged 1 commit into from
May 22, 2024
Merged

use bigint power #7054

merged 1 commit into from
May 22, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented May 22, 2024

Description

#6506

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@luu-alex luu-alex marked this pull request as ready for review May 22, 2024 14:51
Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 624.93 kB → 625 kB (+70 B) +0.01%
Changeset
File Δ Size
../web3-validator/lib/commonjs/validation/numbers.js 📈 +79 B (+1.84%) 4.2 kB → 4.28 kB
../web3-utils/lib/commonjs/converters.js 📈 +66 B (+0.31%) 21.12 kB → 21.18 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 605.64 kB → 605.71 kB (+70 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7f7610a Previous: 3904a46 Ratio
processingTx 8787 ops/sec (±4.22%) 9074 ops/sec (±5.00%) 1.03
processingContractDeploy 38193 ops/sec (±7.13%) 40926 ops/sec (±5.60%) 1.07
processingContractMethodSend 18267 ops/sec (±6.74%) 20386 ops/sec (±7.30%) 1.12
processingContractMethodCall 36406 ops/sec (±5.24%) 40611 ops/sec (±6.33%) 1.12
abiEncode 41676 ops/sec (±6.71%) 45322 ops/sec (±7.04%) 1.09
abiDecode 29341 ops/sec (±6.48%) 30998 ops/sec (±7.93%) 1.06
sign 1560 ops/sec (±3.51%) 1602 ops/sec (±3.59%) 1.03
verify 364 ops/sec (±0.58%) 379 ops/sec (±0.71%) 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.94%. Comparing base (4358140) to head (7f7610a).
Report is 244 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7054      +/-   ##
==========================================
+ Coverage   87.37%   91.94%   +4.56%     
==========================================
  Files         197      215      +18     
  Lines        7548     8313     +765     
  Branches     2059     2287     +228     
==========================================
+ Hits         6595     7643    +1048     
+ Misses        953      670     -283     
Flag Coverage Δ
UnitTests 91.94% <75.00%> (+4.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@avkos avkos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cover new lines with unit test. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants