-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bigint power #7054
use bigint power #7054
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 7f7610a | Previous: 3904a46 | Ratio |
---|---|---|---|
processingTx |
8787 ops/sec (±4.22% ) |
9074 ops/sec (±5.00% ) |
1.03 |
processingContractDeploy |
38193 ops/sec (±7.13% ) |
40926 ops/sec (±5.60% ) |
1.07 |
processingContractMethodSend |
18267 ops/sec (±6.74% ) |
20386 ops/sec (±7.30% ) |
1.12 |
processingContractMethodCall |
36406 ops/sec (±5.24% ) |
40611 ops/sec (±6.33% ) |
1.12 |
abiEncode |
41676 ops/sec (±6.71% ) |
45322 ops/sec (±7.04% ) |
1.09 |
abiDecode |
29341 ops/sec (±6.48% ) |
30998 ops/sec (±7.93% ) |
1.06 |
sign |
1560 ops/sec (±3.51% ) |
1602 ops/sec (±3.59% ) |
1.03 |
verify |
364 ops/sec (±0.58% ) |
379 ops/sec (±0.71% ) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7054 +/- ##
==========================================
+ Coverage 87.37% 91.94% +4.56%
==========================================
Files 197 215 +18
Lines 7548 8313 +765
Branches 2059 2287 +228
==========================================
+ Hits 6595 7643 +1048
+ Misses 953 670 -283
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please cover new lines with unit test. LGTM
Description
#6506
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.