-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle common cases for smart contract errors according to EIP 838 #7155
Handle common cases for smart contract errors according to EIP 838 #7155
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: d446964 | Previous: 9b32205 | Ratio |
---|---|---|---|
processingTx |
21376 ops/sec (±7.86% ) |
23392 ops/sec (±7.52% ) |
1.09 |
processingContractDeploy |
40745 ops/sec (±5.11% ) |
40479 ops/sec (±6.69% ) |
0.99 |
processingContractMethodSend |
16087 ops/sec (±6.32% ) |
16317 ops/sec (±6.87% ) |
1.01 |
processingContractMethodCall |
28265 ops/sec (±6.58% ) |
27614 ops/sec (±8.40% ) |
0.98 |
abiEncode |
43812 ops/sec (±6.76% ) |
46686 ops/sec (±6.17% ) |
1.07 |
abiDecode |
31323 ops/sec (±5.88% ) |
31121 ops/sec (±7.84% ) |
0.99 |
sign |
1523 ops/sec (±3.75% ) |
1556 ops/sec (±0.91% ) |
1.02 |
verify |
366 ops/sec (±0.54% ) |
369 ops/sec (±0.48% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7155 +/- ##
==========================================
- Coverage 94.50% 94.48% -0.02%
==========================================
Files 216 216
Lines 8429 8439 +10
Branches 2315 2318 +3
==========================================
+ Hits 7966 7974 +8
- Misses 463 465 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ds-proxy-contract
Looks good, update changelog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Muhammad-Altabba pls add changelog before merging , thanks
…ds-proxy-contract
Closes #7237