Post-release merge back to master (4.0.6) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release Web3j-Quorum [4.0.4]
Merge master to release branch
…, but upcheck needs an update
Quorum 4.0.4 release
… offset. Add extra constructor to allow passing attempts and sleepDuration parameters to parent constructor.
…nRLPDecodedPayload Fix for setPrivate to use the RLP decoded payload
antonydenyer
approved these changes
Feb 4, 2019
antonydenyer
reviewed
Feb 4, 2019
| @@ -42,7 +42,7 @@ jacocoTestReport { | |||
|
|
|||
|
|
|||
| ext { | |||
| web3jVersion = '4.0.3' | |||
| web3jVersion = '4.0.4' | |||
There was a problem hiding this comment.
Can you double check this version number?
There was a problem hiding this comment.
Yup - this is fine.
antonydenyer
reviewed
Feb 4, 2019
| } | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
@sebaraba is this suppose to be in here?
There was a problem hiding this comment.
IMO we can leave it in, it makes it easier to see how connection to the enclave can be tested in case we ever come back and need to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.