Add more testcases. #5
Conversation
Signed-off-by: Puneetha <puneetha17@gmail.com>
server/server_test.go
Outdated
| @@ -173,6 +186,7 @@ func TestPush(t *testing.T) { | |||
|
|
|||
| rr := httptest.NewRecorder() | |||
| tm := TransactionManager{Enclave: &MockEnclave{}} | |||
| //tm := testInit(t) | |||
There was a problem hiding this comment.
Please can you remove this line if not used
utils/file_test.go
Outdated
| ) | ||
|
|
||
| func TestCreateIpcSocket(t *testing.T) { | ||
| listener, err := CreateIpcSocket("data/crux.db") |
There was a problem hiding this comment.
You should use a temporary directory for this test, as we need to ensure it is cleaned up after use.
config/config.go
Outdated
| @@ -59,6 +59,7 @@ func InitFlags() { | |||
| // TLS is not currently supported | |||
|
|
|||
| pflag.CommandLine.AddGoFlagSet(flag.CommandLine) | |||
| viper.BindPFlags(pflag.CommandLine) | |||
There was a problem hiding this comment.
As we're doing this in ParseCommandLine() should it be duplicated now?
There was a problem hiding this comment.
To Test if the values are initialised correctly, the present configuration is empty as the viper flags are not updated. so edited that function, if the test seems irrelevant, we can avoid the duplication.
server/data/key
Outdated
| @@ -0,0 +1 @@ | |||
| {"data":{"bytes":"W1n0C+NfjcU/cUBXsP5FQ/frU+qpvKQ7Pi/Mu5Hf/Ic="},"type":"unlocked"} | |||
There was a problem hiding this comment.
What's the motivation for adding keys here?
| } | ||
|
|
||
| func TestInit(t *testing.T) { |
There was a problem hiding this comment.
This test does appear to be quite complex - are all of the stages really necessary?
There was a problem hiding this comment.
The most part of the test is to initialise various components, and now separated a small portion which was irrelevant here.
Signed-off-by: Puneetha <puneetha17@gmail.com>
Signed-off-by: Puneetha <puneetha17@gmail.com>
Signed-off-by: Puneetha puneetha17@gmail.com