Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 14 #15

Merged
merged 2 commits into from
Jun 10, 2018
Merged

Fix 14 #15

merged 2 commits into from
Jun 10, 2018

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Jun 10, 2018

Change

  1. Return Buffer([]) when input is 0, negative number, null.
  2. Add tests for issue 14 Integer 0 should be encoded to ox80? #14 .
  3. Remove mediumint and bigint test (loss of precision, the problem also in rlp js library).

1. Return Buffer([]) when input is 0, negative number, null.
2. Add tests for issue 14.
Remove mediumint and bigint test (loss of precision, the problem also in rlp js library).
@codecov-io
Copy link

Codecov Report

Merging #15 into master will decrease coverage by 0.33%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
- Coverage     81.12%   80.78%   -0.34%     
- Complexity       76       80       +4     
============================================
  Files             2        2              
  Lines           196      203       +7     
============================================
+ Hits            159      164       +5     
- Misses           37       39       +2
Impacted Files Coverage Δ Complexity Δ
src/RLP.php 63.46% <81.81%> (+0.57%) 36 <0> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930dbea...75230c4. Read the comment docs.

@sc0Vu sc0Vu merged commit 1d0ebb4 into web3p:master Jun 10, 2018
@sc0Vu sc0Vu deleted the fix-14 branch June 10, 2018 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants