Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support php 80 #204

Closed
wants to merge 3 commits into from
Closed

Support php 80 #204

wants to merge 3 commits into from

Conversation

sc0Vu
Copy link
Member

@sc0Vu sc0Vu commented Apr 6, 2021

Issue: #203

TODO:

  • Fix errors

@99hops
Copy link

99hops commented Aug 12, 2021

Is there anyone working on this? 😃

@mxk1011
Copy link

mxk1011 commented Oct 14, 2021

Please merge this, it works for us!

@momocode-de
Copy link

Any news on when this will be merged?

@samyan
Copy link

samyan commented Jan 3, 2022

Any plan to move it please?

@99hops
Copy link

99hops commented Jan 3, 2022

Just fork/clone the project, update web3.php/composer.json and include it in your local composer.json. Afterwards try what you need if you need it like right now (:

Ex:

"autoload": {
        "psr-4": {
            "Web3\\": "web3.php/src",
            "Web3p\\EthereumTx\\": "web3p/ethereum-tx/src",
            "Web3p\\RLP\\": "web3p/rlp/src",
            "Web3p\\EthereumUtil\\": "web3p/ethereum-util/src"
        }
    }

@samyan
Copy link

samyan commented Jan 3, 2022

Your answer is useless but thanks for trying.

@99hops
Copy link

99hops commented Jan 3, 2022

Thanks for trying to be polite Sam, check this out if you still think it's useless https://github.com/web3p/web3.php/pull/204/files but hey, you know best!

@samyan
Copy link

samyan commented Jan 3, 2022

Don't take my previous comment wrong. But just adding php 8.0 to composer doesn't work. there are very important changes from php 7 to 8 which generates many errors in many php projects if you don't do the migration. To support what I just told you, you can check that the last test which includes php8 has failed precisely for that.

@miguilimzero
Copy link
Contributor

@sc0Vu Just created a pull request with fixed & passing tests for PHP 8: #257.

@sc0Vu
Copy link
Member Author

sc0Vu commented Mar 7, 2022

@SrDante Thanks for the PR. I'll review today.

Since I hadn't update this PR for a while, I'll close this after review your PR.

@sc0Vu sc0Vu closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants