Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an error in the documentation #154

Merged
merged 1 commit into from
Jan 21, 2024

Conversation

lilac-milena
Copy link
Contributor

In the latest version of Chrome, navigator.credentials.create() requires "registrationOptions.user.id" in addition to the "registrationOptions.user.name"
image

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de9e4a3) 92.86% compared to head (63d412f) 92.86%.
Report is 1 commits behind head on master.

❗ Current head 63d412f differs from pull request most recent head 6fa1348. Consider uploading reports for the commit 6fa1348 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   92.86%   92.86%           
=======================================
  Files          16       16           
  Lines        6023     6023           
=======================================
  Hits         5593     5593           
  Misses        430      430           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesCullum JamesCullum merged commit ad1566e into webauthn-open-source:master Jan 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants