change to characterhups for remote players #3704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player. to set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player. Hence calculating/composing it here with obtainted position and quaternion data
codenametiger
changed the title
add console logs to understand code flow for chat multiplayer and hups design Issue is hups clear way to quickly when remote players chat
…tiger/app into 3702-characterhups
This reverts commit e75aee7.
When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player. So target would need updateMatrixWorld to update position, quaternion and scale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player.
Describe your changes
To set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player. Hence calculating/composing it in character-controller.js where position and quaternion data is obtained
What are the steps for a QA tester to test this pull request?
1.Go to 'https://local.webaverse.com/?src=.%2Fscenes%2Fprototype.scn&room=fLgYz'
2.Join another player using same link
3.Press 'Enter' to start chat for any one player and observe character hups window showing character diorama and chat on another player screen.
4. Diorama view for remote player must show the character within the frame for chat character hups window
note: require this pr as well, #3703
Issue ticket number and link
#3702
Screenshots and/or video
Checklist before requesting a review