Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to characterhups for remote players #3704

Closed
wants to merge 5 commits into from
Closed

change to characterhups for remote players #3704

wants to merge 5 commits into from

Conversation

codenametiger
Copy link
Contributor

@codenametiger codenametiger commented Sep 12, 2022

When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player.

Describe your changes

To set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player. Hence calculating/composing it in character-controller.js where position and quaternion data is obtained

What are the steps for a QA tester to test this pull request?

1.Go to 'https://local.webaverse.com/?src=.%2Fscenes%2Fprototype.scn&room=fLgYz'
2.Join another player using same link
3.Press 'Enter' to start chat for any one player and observe character hups window showing character diorama and chat on another player screen.
4. Diorama view for remote player must show the character within the frame for chat character hups window

note: require this pr as well, #3703

Issue ticket number and link

#3702

Screenshots and/or video

Img_1
Img_2

Checklist before requesting a review

  • I have performed a self-review of my code
  • I am not adding any irrelevant code or assets
  • I am only including the changes needed to implement the change
  • I have playtested and intentionally tried to find error cases but couldn't
  • I have completed the entire QA checklist on my PR

When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player. to set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player. Hence calculating/composing it here with obtainted position and quaternion data
@codenametiger codenametiger changed the title change to chracterhups for remote players change to characterhups for remote players Sep 13, 2022
add console logs to understand code flow for chat multiplayer and hups design
Issue is hups clear way to quickly when remote players chat
When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player.
So target would need updateMatrixWorld to update position, quaternion and scale
@codenametiger codenametiger deleted the 3702-characterhups branch September 16, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant