character portrait position in diorama #3713
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chatting with another player, the diorama in the character hups window for the remote player is buggy. The character is out of frame in the character hups for remote player.
Describe your changes
To set up side camera in diorama.js, position, quaternion and scale is obtained from target.matrixworld.decompose which does not seem to be updated for remote player.
So target would need updateMatrixWorld to update position, quaternion and scale
What are the steps for a QA tester to test this pull request?
1.Go to 'https://local.webaverse.com/?src=.%2Fscenes%2Fprototype.scn&room=fLgYz'
2.Join another player using same link
3.Press 'Enter' to start chat for any one player and observe character hups window showing character diorama and chat on another player screen.
4. Diorama view for remote player must show the character within the frame for chat character hups window
Issue ticket number and link
#3702
Screenshots and/or video
Checklist before requesting a review