Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorldPainter: Dynmap won't render Leafs. (with fullrender) #3104

Closed
ghost opened this issue Aug 19, 2020 · 18 comments
Closed

WorldPainter: Dynmap won't render Leafs. (with fullrender) #3104

ghost opened this issue Aug 19, 2020 · 18 comments
Labels
Bug Render Issues Tracker for all issues related to black bars or not fully generated maps upon chunk generation Workaround available

Comments

@ghost
Copy link

ghost commented Aug 19, 2020

Issue Description: The dynmap does not render leafs (all sorts of leafs) when fullrendering by itselfs. Although, it does render all the leafs when I personally load in the chunks (by flying over them), and dynmap renders those.
Sample screen: https://gyazo.com/b1b5353831543f7952c2380b4372e4ca. As you can see, the place where I stand, leafs are visible. All the rest of the forest is rendered without leafs, making only the logs visible. (bit more black)

  • Dynmap Version: Dynmap-3.1-beta-3-spigot
  • Server Version: spigot 1.16.1 build.
  • Pastebin of Configuration.txt: https://justpaste.it/3fh9k (sorry, pastebin was down). But its a default config without much edits.
  • Server Host (if applicable): Syntexhosting - The Netherlands
  • Pastebin of crashlogs or other relevant logs: (no crash caused)
  • Other Relevant Data/Screenshots: https://gyazo.com/b1b5353831543f7952c2380b4372e4ca (same as above)
  • Steps to Replicate: (Sorry I don't understand this question. No issue like this has occoured

[ ] I have looked at all other issues and this is not a duplicate
[ ] I have been able to replicate this

@ghost ghost added the Bug Report label Aug 19, 2020
@ghost ghost closed this as completed Aug 19, 2020
@FedUpWith-Tech
Copy link
Collaborator

What version was this map made on?

@ghost ghost reopened this Aug 19, 2020
@ghost
Copy link
Author

ghost commented Aug 19, 2020

What version was this map made on?

This map was made on Worldpainter, which I had no problems with for years. Ingame the leafs are all fine. Its just the dynmap problem. The worldpainter map was rendered with the option 1.13+ (and supports 1.16)

@ghost
Copy link
Author

ghost commented Aug 19, 2020

I am now seeing the config option "Transparent leafs" which may be the solution. If this works im so sorry for wasting your time, and me being once again stupid ;3

EDIT: Didn't help.

@FedUpWith-Tech
Copy link
Collaborator

Duplicate of #3046

World painter breakes leaves and some grass textures, we are working on redoing the chunk loading engine to fix this but no eta

@ghost
Copy link
Author

ghost commented Aug 19, 2020

Alright sorry, must have missed that one in my search for a duplicate.
I understand theirs no eta, but are we speaking of days? Weeks? Months? Because I would like to have a fix for shit matter.

@FedUpWith-Tech
Copy link
Collaborator

I can't say. Its not the biggest priority right now and the dev doesn't have a bunch of time to work on super large fixes/plugin rewrites right now. Could be next week or next year

@FedUpWith-Tech FedUpWith-Tech added Bug Render Issues Tracker for all issues related to black bars or not fully generated maps upon chunk generation and removed Bug Report labels Aug 20, 2020
@bloggy
Copy link

bloggy commented Feb 25, 2021

Same issue here. Leaves not being rendered on a worldpainter map. Still no fix for this?

@Mint-101
Copy link

Mint-101 commented May 7, 2021

I need a fix for this. Anybody?

@Mint-101
Copy link

Mint-101 commented May 7, 2021

I actually found a way to fix this. It's not perfect but if you load in some chunks on your Minecraft client Dynmap will fix the leaves. Eventually, when your map has been fully loaded by players there will be no more invisible leaves. It's a scuffed solution but for many, it's just going to have to do.

EDIT: I was, unfortunately, wrong but I did learn something else. Some of my Dynmap custom trees rendered correctly although most didn't. I do not have the time to go more in-depth with this and test different custom trees to see which ones render, but it seems to me that trees with matching log and leaf types will render correctly.

@connorgillespie
Copy link

Bump. Having the same issue. The map artist for my server uses WorldPainter and practically every tree has no leaves. I don't have a solution and the solution provided by @Mint-101 didn't really seem to work. It would be really appreciated if this could be fixed since our server uses WorldPainter for literally every build ... Here is a screenshot if anyone needed it.

@leivaa21
Copy link

leivaa21 commented Jul 8, 2021

Bump. I have the same issue and I dont know how to fix it, some news?

@FedUpWith-Tech
Copy link
Collaborator

Pre-1.18 here is the workaround/fix for this:
WorldPainter/EarthMC maps has many known issues with Dynmap such as, incomplete render, only rendering where players have visited, or not rendering leaves and other foliage.
This is a result of how worldpainter generates maps and is not an issue with Dynmap, luckily there is a fix.

  1. Download the WorldBorder plugin: WorldBorder
  2. Pause Dynmap: /dynmap pause all
  3. Run worldborder with the force flag: /wb [worldname] fill [freq] [pad] [force]
  • [worldname] is the name of your world folder
  • [freq] is how many chunks a second are generated, 20 is the default. WARNING: setting this too high will cause server lag
  • [pad] how many chunks beyond the border to generate, this makes sure that if a player visits the border, all chunks are already generated. The default is 208, I recommend setting this to 0 for EarthMC
  • [force] This must be set to true
  1. Wait for worldborder to finish
  2. Unpause Dynmap /dynmap pause none, you may have to restart the fullrender using /dynmap fullrender [worldname]

As of right now there is no workaround for 1.18 but we are investigating a more permanent fix than the force fill hack.

@bloggy
Copy link

bloggy commented Feb 14, 2022

Still no solution for 1.18.x ?

@JurgenKuyper
Copy link
Collaborator

Still no solution for 1.18.x ?
did you do what FedUpWithTech said in the comment above yours? that is the fix for this.

@bloggy
Copy link

bloggy commented Feb 14, 2022

Yeah he says:
"As of right now there is no workaround for 1.18 but we are investigating a more permanent fix than the force fill hack."

@JurgenKuyper
Copy link
Collaborator

no, there hasn't been one, the dev is still busy with optimising the dynmap code, and fixing textures and such.

@mikeprimm-triva
Copy link
Contributor

Hey - do we have a good reproduce on this on current 3.4 SNAPSHOT? I'll be happy to look at this, but I need a current code reproduce, since I'm not seeing this in any scenarios that I test with. If this is about WorldPainter created maps, if you could give me a download of a world data (or just a portion of one) that exhibits the problem (I'm not going to screw around with old WorldPainter versions and such to reproduce this... just no time for that...)

@generrosity generrosity changed the title Dynmap won't render Leafs. (with fullrender) WorldPainter: Dynmap won't render Leafs. (with fullrender) Feb 15, 2022
@mikeprimm
Copy link
Member

No response on request for sample which exhibits problem - closing as unreproducable until this changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Render Issues Tracker for all issues related to black bars or not fully generated maps upon chunk generation Workaround available
Projects
None yet
Development

No branches or pull requests

8 participants