Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www.ndtv.com – Text is cropped on “Auto” page #7468

Closed
softvision-oana-arbuzov opened this issue Jun 15, 2017 · 3 comments
Closed

www.ndtv.com – Text is cropped on “Auto” page #7468

softvision-oana-arbuzov opened this issue Jun 15, 2017 · 3 comments

Comments

@softvision-oana-arbuzov
Copy link
Member

URL: https://auto.ndtv.com/
Browser / Version: Firefox Mobile Nightly 56.0a1 (2017-06-14)
Operating System: LG G5 (Android 7.0) - Resolution 1440 x 2560 pixels (~554 ppi pixel density)
Problem type: Text is not visible

Steps to Reproduce

  1. Navigate to: https://auto.ndtv.com/
  2. Scroll down to “News” section and observe text.

Expected Behavior:
Text is fully visible.

Actual Behavior:
Text is cropped.

Note:

  1. Also reproducible for “Expert Reviews” section.
  2. Reproducible on Firefox 53.0.2 Release.
  3. Not reproducible on Chrome (Mobile) 58.0.3029.83.
  4. Screenshot attached.

Watchers:
@softvision-sergiulogigan
@softvision-oana-arbuzov

sv; country: in

Screenshot Description

From webcompat.com with ❤️

@softvision-oana-arbuzov
Copy link
Member Author

This might be a duplicate of #866102

@softvision-oana-arbuzov softvision-oana-arbuzov changed the title auto.ndtv.com - text is not visible www.ndtv.com – Text is cropped on “Auto” page Jun 15, 2017
@karlcow
Copy link
Member

karlcow commented Jun 20, 2017

So yes it's a kind of issue related to -webkit-line-clamp where they used a height to compensate.

As you can see if increase the box height artificially on one element.

Screenshot Description

<div class="flexgrid">
    <figure class="media-list__img flexgrid__cell img-wrap">
        <img src="https://i.ndtvimg.com/i/2017-06/bmw-5-series-plug-in-hybrid_250x143_51497879675.jpg"
            data-webp="https://i.ndtvimg.com/i/2017-06/bmw-5-series-plug-in-hybrid_250x143_51497879675.jpg"
            class="img-responsive js-defer" alt="Auto Supplier Magna To Manufacture BMW 5 Series Plug-In Hybrids"
            title="Auto Supplier Magna To Manufacture BMW 5 Series Plug-In Hybrids">
    </figure>
    <div class="media-list__content flexgrid__cell">
        <div class="media-list__title h__truncate" style="height: 42px;">Auto Supplier Magna To Manufacture BMW 5 Series
            Plug-In Hybrids</div>
    </div>
</div>
.h__truncate, .h__txt-truncate {
	overflow: hidden;
	text-overflow: ellipsis;
}

.h__truncate {
	display: -webkit-box;
	position: relative;
	-webkit-line-clamp: 2;
	-webkit-box-orient: vertical;
}
.media-list__title {
	height: 32px;
	line-height: 1.2;
	font-size: 1.4rem;
}

.media-list--news .media-list__title {
	max-height: 50px;
	-webkit-line-clamp: 3;
}

@karlcow
Copy link
Member

karlcow commented Jun 20, 2017

@karlcow karlcow added this to the duplicate milestone Oct 30, 2017
@karlcow karlcow closed this as completed Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants