Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type for ChromeDriver refs #4989

Closed
lamkovod opened this issue Feb 3, 2020 · 2 comments
Closed

Fix type for ChromeDriver refs #4989

lamkovod opened this issue Feb 3, 2020 · 2 comments
Labels
good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript

Comments

@lamkovod
Copy link
Contributor

lamkovod commented Feb 3, 2020

Environment (please complete the following information):

  • WebdriverIO version: [e.g. 5.18.6]

Describe the bug
Type for 'goog:chromeOptions'.refs is not valid.
In Chrome documentation (https://chromedriver.chromium.org/capabilities) code example can be found:

Map<String, Object> prefs = new HashMap<String, Object>();
prefs.put("profile.default_content_settings.popups", 0);

Just replace prefs?: string[] -> prefs?: { [name: string]: string | number | boolean }
@christian-bromann christian-bromann added good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript labels Feb 3, 2020
@christian-bromann
Copy link
Member

@lamkovod feel free to provide a PR with a fix. Thanks!

@lamkovod lamkovod mentioned this issue Feb 3, 2020
Merged
1 task
christian-bromann pushed a commit that referenced this issue Feb 10, 2020
@lamkovod
Fix for Chrome refs type (#4989) (#4990)
30ff73e 
* Fix for Chrome refs type (#4989)

* Test Chrome Firefox Config type
@christian-bromann
Copy link
Member

PR got merged. Closing. Thanks for the contribution!

christian-bromann pushed a commit that referenced this issue Feb 14, 2020
@lamkovod @christian-bromann
Fix for Chrome refs type (#4989) (#4990)
363b06b 
* Fix for Chrome refs type (#4989)

* Test Chrome Firefox Config type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first pick a reasonable task to start getting familiar with the code base help wanted Issues that are free to take by anyone interested TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christian-bromann @lamkovod