Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: support transposing instruments in part data #116

Merged
merged 1 commit into from
Oct 4, 2020
Merged

api: support transposing instruments in part data #116

merged 1 commit into from
Oct 4, 2020

Conversation

webern
Copy link
Owner

@webern webern commented Oct 4, 2020

Closes #115

This adds an optional field to PartData named transposition. This allows you to
specify an instruments transposition at the start of the score. MusicXML encodes
this in the measure data so that you can change transpositions throughout a
part. This api implementation only allows you to set the transposition at the
start of the score (the most common use case). Subsequent instrument and
transposition changes are currently unsupported in the api.

@webern webern marked this pull request as draft October 4, 2020 05:31
@webern webern force-pushed the transposition-pr branch 2 times, most recently from e710c99 to 7bc0f59 Compare October 4, 2020 16:08
webern
webern commented Oct 4, 2020
View reviewed changes
Copy link
Owner Author

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLion really messed things up

Documents/musicxml-3.1.xsd Outdated Show resolved Hide resolved
Documents/musicxml.xsd Outdated Show resolved Hide resolved
Resources/custom/transposition.musicxml Show resolved Hide resolved
Resources/ksuite/k004a_Technical.xml Outdated Show resolved Hide resolved
Resources/lysuite/ly32a_Notations.xml Outdated Show resolved Hide resolved
Sourcecode/private/mx/impl/ScoreWriter.h Outdated Show resolved Hide resolved
Sourcecode/private/mx/impl/TechnicalFunctions.cpp Outdated Show resolved Hide resolved
Sourcecode/private/mxtest/api/TranspositionTest.cpp Show resolved Hide resolved
Sourcecode/private/mxtest/core/HarmonicTest.cpp Outdated Show resolved Hide resolved
Sourcecode/private/mxtest/core/TouchingPitchTest.cpp Outdated Show resolved Hide resolved
@webern
api: support transposing instruments in part data
9f67a42 
This adds an optional field to PartData named transposition. This allows you to
specify an instruments transposition at the start of the score. MusicXML encodes
this in the measure data so that you can change transpositions throughout a
part. This api implementation only allows you to set the transposition at the
start of the score (the most common use case). Subsequent instrument and
transposition changes are currently unsupported in the api.
@webern webern marked this pull request as ready for review October 4, 2020 21:31
@webern webern merged commit 9ef9a93 into master Oct 4, 2020
@webern webern deleted the transposition-pr branch October 4, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api: support transpose element
1 participant
@webern