-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new page support - refactor page layout system layout and system data #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
Adds support for
new-page
attributes and page layout. Unfortunately doing so became a large crusade of breaking changes. The affected fields ofScoreData
arelayout
andsystems
.What used to be the
LayoutData
class has been renamed toDefaultsData
. This name change freed up the nameLayoutsData
to be used for a new class that better fits the name.The
std::set<SystemData> systems
field ofScoreData
has been replaced bystd::map<MeasureIndex, LayoutData>
.LayoutData
is a new class (not to be confused withDefaultsData
which previously held the name).LayoutData
holds aSystemData
and aPageData
(new) to specify system and page layout.SystemData
andDefaultsData
(which used to be calledLayoutData
) have some refactoring with the introduction of the following classes:-
LeftRight
-
MarginsData
-
PageLayoutData
-
PageMarginsData
-
SizeData
-
SystemLayoutData
@p-groarke , I'm hopeful that you won't be horribly affected by all the churn. I think it's for the better. When you mentioned that you didn't like the way
systems
are specified, I think that switching to amap
probably makes it more usable. Ultimately if you just want to specify system and page breaks, it can be done like this:Let me know if you need any help with breakage.