Skip to content

Commit 3ca3583

Browse files
committed
feat(journeys): use new moveMouse defaults
1 parent ba81df9 commit 3ca3583

File tree

4 files changed

+8
-13
lines changed

4 files changed

+8
-13
lines changed

test/journeys/lib/test-helpers/space-widget/messaging.js

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ export function verifyFilesActivityTab(aBrowser, fileName, hasThumbnail) {
9797
export function flagMessage(testObject, messageToFlag) {
9898
testObject.browser.waitUntil(() =>
9999
testObject.browser.element(elements.lastActivityText).getText() === messageToFlag);
100-
101100
moveMouse(testObject.browser, elements.lastActivityText);
102101
testObject.browser.waitUntil(() =>
103102
testObject.browser
@@ -111,9 +110,6 @@ export function flagMessage(testObject, messageToFlag) {
111110
.element(elements.flagButton)
112111
.click();
113112

114-
// Move mouse away to hide hover buttons
115-
moveMouse(testObject.browser, elements.lastActivityText, 0, 150);
116-
117113
// Verify it is highlighted, showing it was flagged
118114
testObject.browser.waitUntil(() => testObject.browser
119115
.element(elements.lastActivity)
@@ -123,7 +119,7 @@ export function flagMessage(testObject, messageToFlag) {
123119

124120
// Since we automatically activate the flag icon before confirming it on the server,
125121
// we need to wait a certain timeframe to allow server to recognize flag
126-
testObject.browser.pause(1500);
122+
testObject.browser.pause(2500);
127123
}
128124

129125
/**
@@ -134,7 +130,7 @@ export function flagMessage(testObject, messageToFlag) {
134130
*/
135131
export function removeFlagMessage(testObject, messageToUnflag) {
136132
testObject.browser.waitUntil(() =>
137-
testObject.browser.element(elements.lastActivityText).getText() === messageToUnflag);
133+
testObject.browser.element(elements.lastActivityText).getText() === messageToUnflag, 'message was not found');
138134

139135
testObject.browser.waitUntil(() => testObject.browser
140136
.element(elements.lastActivity)
@@ -147,8 +143,6 @@ export function removeFlagMessage(testObject, messageToUnflag) {
147143
.element(elements.flagButton)
148144
.click();
149145

150-
moveMouse(testObject.browser, elements.lastActivityText, 0, 150);
151-
152146
testObject.browser.waitUntil(() => testObject.browser
153147
.element(elements.lastActivity)
154148
.element(elements.highlighted)
@@ -167,6 +161,7 @@ export function canDeleteMessage(testObject, messageToDelete) {
167161

168162
return testObject.browser
169163
.element(`${elements.lastActivity} ${elements.deleteMessageButton}`)
164+
// Delete button is hidden but still exists
170165
.isExisting();
171166
}
172167

test/journeys/specs/multiple/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ describe('Multiple widgets on a page', () => {
190190

191191
it('displays a call button on hover', () => {
192192
displayIncomingMessage(browserLocal, lorraine, oneOnOneConversation, 'Can you call me?', true);
193-
moveMouse(browserLocal, recentsElements.firstSpace, 10, 10);
193+
moveMouse(browserLocal, recentsElements.firstSpace);
194194
browserLocal.waitUntil(() =>
195195
browserLocal.element(`${recentsElements.callButton}`).isVisible(),
196196
1500,

test/journeys/specs/recents/dataApi/basic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ describe('Widget Recents', () => {
147147

148148
it('displays a call button on hover', () => {
149149
displayIncomingMessage(browserLocal, lorraine, conversation, 'Can you call me?');
150-
moveMouse(browserLocal, elements.firstSpace, 10, 10);
150+
moveMouse(browserLocal, elements.firstSpace);
151151
// browserLocal.debug();
152152
browserLocal.waitUntil(() =>
153153
browserLocal.element(`${elements.callButton}`).isVisible(),
@@ -174,7 +174,7 @@ describe('Widget Recents', () => {
174174

175175
it('displays a call button on hover', () => {
176176
displayIncomingMessage(browserLocal, lorraine, oneOnOneConversation, 'Can you call me?', true);
177-
moveMouse(browserLocal, elements.firstSpace, 10, 10);
177+
moveMouse(browserLocal, elements.firstSpace);
178178
// browserLocal.debug();
179179
browserLocal.waitUntil(() =>
180180
browserLocal.element(`${elements.callButton}`).isVisible(),

test/journeys/specs/recents/global/basic.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ describe('Widget Recents', () => {
152152

153153
it('displays a call button on hover', () => {
154154
displayIncomingMessage(browserLocal, lorraine, conversation, 'Can you call me?');
155-
moveMouse(browserLocal, elements.firstSpace, 10, 10);
155+
moveMouse(browserLocal, elements.firstSpace);
156156
// browserLocal.debug();
157157
browserLocal.waitUntil(() =>
158158
browserLocal.element(`${elements.callButton}`).isVisible(),
@@ -238,7 +238,7 @@ describe('Widget Recents', () => {
238238

239239
it('displays a call button on hover', () => {
240240
displayIncomingMessage(browserLocal, lorraine, oneOnOneConversation, 'Can you call me?', true);
241-
moveMouse(browserLocal, elements.firstSpace, 10, 10);
241+
moveMouse(browserLocal, elements.firstSpace);
242242
// browserLocal.debug();
243243
browserLocal.waitUntil(() =>
244244
browserLocal.element(`${elements.callButton}`).isVisible(),

0 commit comments

Comments
 (0)