Skip to content

Commit c59f465

Browse files
Bernie Zangadamweeks
authored andcommitted
fix(r-m-media): remove extraneous event listeners
1 parent 232e790 commit c59f465

File tree

4 files changed

+25
-35
lines changed

4 files changed

+25
-35
lines changed

packages/node_modules/@ciscospark/redux-module-media/src/__snapshots__/actions.test.js.snap

Lines changed: 0 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/node_modules/@ciscospark/redux-module-media/src/actions.js

Lines changed: 0 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/node_modules/@ciscospark/redux-module-media/src/reducer.js

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/journeys/specs/oneOnOne/dataApi/startup-settings.js

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,27 @@ describe('Widget Space: One on One: Data API Settings', () => {
114114
});
115115
});
116116

117+
describe('opens using legacy toPersonEmail', () => {
118+
before('inject token', () => {
119+
browserLocal.execute((localAccessToken, localToUserEmail) => {
120+
const csmmDom = document.createElement('div');
121+
csmmDom.setAttribute('class', 'ciscospark-widget');
122+
csmmDom.setAttribute('data-toggle', 'ciscospark-space');
123+
csmmDom.setAttribute('data-access-token', localAccessToken);
124+
csmmDom.setAttribute('data-to-person-email', localToUserEmail);
125+
csmmDom.setAttribute('data-initial-activity', 'meet');
126+
document.getElementById('ciscospark-widget').appendChild(csmmDom);
127+
window.loadBundle('/dist-space/bundle.js');
128+
}, spock.token.access_token, mccoy.email);
129+
browserLocal.waitForVisible(elements.meetWidget);
130+
});
131+
132+
it('opens meet widget', () => {
133+
browserLocal.waitForVisible(elements.meetButton);
134+
browserLocal.refresh();
135+
});
136+
});
137+
117138
describe('start call setting', () => {
118139
before('inject token', () => {
119140
browserRemote.execute((localAccessToken, localToUserEmail) => {
@@ -155,26 +176,6 @@ describe('Widget Space: One on One: Data API Settings', () => {
155176
});
156177
});
157178

158-
describe('opens using legacy toPersonEmail', () => {
159-
before('inject token', () => {
160-
browserLocal.execute((localAccessToken, localToUserEmail) => {
161-
const csmmDom = document.createElement('div');
162-
csmmDom.setAttribute('class', 'ciscospark-widget');
163-
csmmDom.setAttribute('data-toggle', 'ciscospark-space');
164-
csmmDom.setAttribute('data-access-token', localAccessToken);
165-
csmmDom.setAttribute('data-to-person-email', localToUserEmail);
166-
csmmDom.setAttribute('data-initial-activity', 'meet');
167-
document.getElementById('ciscospark-widget').appendChild(csmmDom);
168-
window.loadBundle('/dist-space/bundle.js');
169-
}, spock.token.access_token, mccoy.email);
170-
browserLocal.waitForVisible(elements.meetWidget);
171-
});
172-
173-
it('opens meet widget', () => {
174-
browserLocal.waitForVisible(elements.meetButton);
175-
browserLocal.refresh();
176-
});
177-
});
178179

179180
/* eslint-disable-next-line func-names */
180181
afterEach(function () {

0 commit comments

Comments
 (0)