-
Notifications
You must be signed in to change notification settings - Fork 121
fix(space-widget): adjust colors for links, system message and external space message #1455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (6)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Is there a dark theme in the space widgets and if yes, how are these changes affecting the dark theme?
- Please update the PR title with right component & message:
fix(space-widget): adjust colors for links, system message and external space message
- In the demo, when you hover over the link, why is the color for the message "Testing" also changes?
Currently, Space Widget doesn’t support theme selection and uses only the default styling. The changes in this PR only affect that default theme. If theme support is introduced in the future, we’ll need to update the application-wide CSS color variables to align with Momentum theme colors |
The current HTML structure has an |
Were you able to check if this is fixable easily or requires a component level change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The unit tests are failing. Please check
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
COMPLETES # https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-564411
This pull request addresses
FCC accessibility color contrast issue
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-564411
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-564410
https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-564409
by making the following changes
Updated CSS to change the color in order to meet the accessibility contrast requirements
Vidcast Link
https://app.vidcast.io/share/1e89ac89-b7ac-4ace-86d9-9653d82e4ea3
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging