Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashed CSS property names are only partially underlined in the VS Code extension #3130

Closed
antross opened this issue Oct 17, 2019 · 0 comments · Fixed by #3138
Closed

Dashed CSS property names are only partially underlined in the VS Code extension #3130

antross opened this issue Oct 17, 2019 · 0 comments · Fixed by #3138
Assignees
@sarvaje
Labels
area:vscode type:bug
Milestone
1910-2

Comments

@antross
Copy link
Member

antross commented Oct 17, 2019

E.g. if a report is generated for background-color, only background ends up underlined.

Fixing this probably requires a few steps:

  • Introduce support for ranges on Problem (e.g. adding an optional endColumn and endLine)
  • Update affected hints to provide ranges with reports
  • Update the VS Code extension to map them to VS Code ranges
@antross antross added this to the 1910-2 milestone Oct 17, 2019
@sarvaje sarvaje self-assigned this Oct 17, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 18, 2019
@sarvaje
Fix: Allow ranged location in css.
5f00e0c 
Fix webhintio#3130
@sarvaje sarvaje mentioned this issue Oct 18, 2019
Merged
7 tasks
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 18, 2019
@sarvaje
Fix: Allow ranged location in css.
0260698 
Fix webhintio#3130
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 22, 2019
@sarvaje
Fix: Allow ranged location in css.
7d0b29f 
Fix webhintio#3130
molant pushed a commit that referenced this issue Oct 25, 2019
@sarvaje @molant
New: Allow ranged locations in CSS
de43df9 
Fix #3130
Close #3138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarvaje sarvaje

Labels
area:vscode type:bug
Projects
None yet
Milestone
1910-2
Development

Successfully merging a pull request may close this issue.

Fix: Allow ranged location in css. sarvaje/hint
2 participants
@antross @sarvaje