Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashed CSS property names are only partially underlined in the VS Code extension #3130

Closed
antross opened this issue Oct 17, 2019 · 0 comments · Fixed by #3138
Assignees
Milestone

Comments

@antross
Copy link
Member

@antross antross commented Oct 17, 2019

E.g. if a report is generated for background-color, only background ends up underlined.

Fixing this probably requires a few steps:

  • Introduce support for ranges on Problem (e.g. adding an optional endColumn and endLine)
  • Update affected hints to provide ranges with reports
  • Update the VS Code extension to map them to VS Code ranges
@antross antross added this to the 1910-2 milestone Oct 17, 2019
@sarvaje sarvaje self-assigned this Oct 17, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 18, 2019
@sarvaje sarvaje referenced this issue Oct 18, 2019
6 of 7 tasks complete
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 18, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Oct 22, 2019
@molant molant closed this in #3138 Oct 25, 2019
molant added a commit that referenced this issue Oct 25, 2019
Fix #3130
Close #3138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.