Add rule to check the web app manifest extension #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrra
commented
Mar 15, 2017
| /** Finds the Location of an HTMLElement in the document */ | ||
| const findElementLocation = (element: HTMLElement): ProblemLocation => { | ||
|
|
||
| const html = element.ownerDocument.children[0].outerHTML; |
There was a problem hiding this comment.
@molant Pages usually have content before <html> (e.g.: <!doctype html>), so using element.ownerDocument.children[0].outerHTML is not accurate.
There was a problem hiding this comment.
Then find me a better way :)
Already did. I just mention this so you know why I stopped using it.
molant
approved these changes
Mar 15, 2017
|
Merging this. I'll probably refactor the findElement portion a bit but this is OK to have it merged and unblock other parts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule Details
This rule warns against using non-standard file extensions for the web app manifest file, if the recommended
.webmanifestfile extension is not used.While the
.webmanifestfile extension is not enforced by the specification, nor is it required by browsers, using it makes it:Resources:
Ref #32