Update home page with new content #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I just sent it to you. |
|
Alright, adding the illustration now. :P |
|
I will say it does feel slightly off, like @antross called out, with the two circular images.
|
|
|
hxlnt
approved these changes
Sep 24, 2019
|
Looks great to me! :) Thanks! |
sarvaje
reviewed
Sep 24, 2019
There was a problem hiding this comment.
LGTM.
Only one nit, I think the svgs can be compressed a little bit more. You can try this tool: https://jakearchibald.github.io/svgomg/
antross
approved these changes
Sep 24, 2019
|
@sarvaje Doesn't look like that tool makes the SVGs meaningfully smaller (only saves less than 1KB on each) |
|
ok |
sarvaje
approved these changes
Sep 24, 2019
molant
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
Short description of the change(s)
Fixes #765 and #762
Updates home page with new content
There's still one illustration we're missing. I've commented where that needs to go. I wanted to submit this PR so that I'm not blocking getting the home page updated since I'll be largely unavailable/sporadically online for the next few days.
I'm trying to take a screenshot of the page but my extension for doing so doesn't work on localhost. Hrmm.