feat: webapp commit message support #10
Conversation
package.json
Outdated
| "got": "^11.3.0", | ||
| "lodash.get": "^4.4.2" | ||
| "lodash.get": "^4.4.2", | ||
| "typescript": "^5.0.3" |
There was a problem hiding this comment.
These deps should go into devDeps, no?
There was a problem hiding this comment.
typescript is required for the build process
There was a problem hiding this comment.
If it's build-related, this should then be a dev dep.
There was a problem hiding this comment.
I agree, needs to be moved to dev-deps in that sense.
|
@adrians5j how do we resolve the |
|
Please just resolve the merge conflict. It's just dist/build. Whatever you do, no worries about it, I'll rebuild again before I release. |
I'm not sure how to resolve merge conflicts of the build/transpiled files, |
|
Just accept yours. It's not a problem, because I'll do a rebuild once this is merged. |
|
I think that's permission to force push @Steveantor |
|
Steveantor told me that @adrians5j needs to force merge and that from here its out of his hands. |
|
I can't do changes in fork branches. Changes can be done only on your side. P.S. I'm merging via GH, and it prevents me from merging b/c of a conflict. |
You have two options:
Sorry mate the road ends here with our team. |
|
@adrians5j no more merge conflict |
|
@adrians5j will you look into this PR again? |
GitHub supports suggestions during the pull request review process. This process to make the change to the code, and push the commit is entirely inside of the GitHub pull request review user interface.
The default git message begins with "Update " and so we decided to add support for this on our fork.
More context is available here: ubiquity/ubiquity-dollar#623 (review)