Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-file-manager): tags listing error #2114

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

brunozoric
Copy link
Contributor

Changes

In FileManager DynamoDB storage operations list tags breaks if any file uploaded did not have tags.

api-file-manager

Added a check before create and update of file and set empty array if no tags defined - this is a fix for new / updated files.

api-file-manager-ddb

Use empty array as default if no tags inserted with the file - this is a fix for existing files.

How Has This Been Tested?

Jest and manually.

@brunozoric brunozoric self-assigned this Dec 14, 2021
@brunozoric brunozoric added this to the 5.19.1 milestone Dec 14, 2021
@brunozoric brunozoric added the bug label Dec 14, 2021
@brunozoric brunozoric changed the title fix(api-file-manager): tags listing when file with no tags fix(api-file-manager): tags listing error Dec 14, 2021
@brunozoric brunozoric merged commit d9c638b into v5 Dec 14, 2021
@brunozoric brunozoric deleted the fix/api-file-manager/tags-listing branch December 14, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant